Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 #73

Merged
merged 2 commits into from
Apr 5, 2024
Merged

v2.0 #73

merged 2 commits into from
Apr 5, 2024

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented Apr 4, 2024

Description

  • removed deprecated
  • CHANGELOG updated for v2.0

edit

  • removed MessageEvents.disposeEngine and MessageEvents.stopLoop enums alongside _stopLoop() and _disposeEngine() methods because were used in the old async disposeEngine(). All that work is now done by deinit().

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

## Description

- removed deprecated
- CHANGELOG updated for v2.0

## Type of Change

- [ ] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
- [ ] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [x] 📝 Documentation
- [x] 🗑️ Chore
Copy link
Owner Author

@alnitak alnitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to delete the fix_data.yaml file and the test_fixes directory?

In the CHANGELOG I have written the major changes since v1.2.5. Is that enough? Please, take a look if I missed something. I left the pre versions for reference before deleting them (if you agree to delete them).

Tests passed on Linux, Android and Windows.

@alnitak alnitak requested a review from filiph April 4, 2024 21:50
@alnitak alnitak changed the title v2.0.0-pre.5 v2 Apr 4, 2024
@alnitak alnitak changed the title v2 v2.0 Apr 4, 2024
Copy link
Collaborator

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me play around with it a bit and then we can publish on pub.dev.

Thanks!

@filiph
Copy link
Collaborator

filiph commented Apr 5, 2024

Do I need to delete the fix_data.yaml file and the test_fixes directory?

No no, let's keep these. I don't know if they'll still work but it's worth having them around for a while.

In the CHANGELOG I have written the major changes since v1.2.5. Is that enough? Please, take a look if I missed something.

Makes sense to me!

I left the pre versions for reference before deleting them (if you agree to delete them).

I think we can keep those. The people who're still on 1.x will be interested in seeing the path, I think.

Tests passed on Linux, Android and Windows.

I'll try macOS and iOS once it lands.

@filiph filiph marked this pull request as ready for review April 5, 2024 11:18
@filiph filiph merged commit 965ac0e into main Apr 5, 2024
1 check passed
@alnitak alnitak deleted the v2 branch April 5, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants