Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Init error on hot restart #81 #82

Merged
merged 6 commits into from
May 6, 2024
Merged

fix: Init error on hot restart #81 #82

merged 6 commits into from
May 6, 2024

Conversation

alnitak
Copy link
Owner

@alnitak alnitak commented May 6, 2024

Description

Fix hot reload SoLoudPlayerAlreadyInitializedException issue #81.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alnitak alnitak requested a review from filiph May 6, 2024 09:04
filiph
filiph approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

lib/src/soloud.dart Show resolved Hide resolved
alnitak and others added 2 commits May 6, 2024 14:21
@alnitak @filiph
Update lib/src/soloud.dart
79db736 
Co-authored-by: Filip Hracek <filiph@users.noreply.github.com>
@alnitak
format fix
c03803f
@alnitak
Copy link
Owner Author

alnitak commented May 6, 2024

Great! Thank you.

@alnitak alnitak merged commit bd77bb1 into main May 6, 2024
1 check passed
@alnitak alnitak deleted the dev branch May 6, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiph filiph filiph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alnitak @filiph