fix: Fix deadlock raised in neilotoole#11

alpacahq · Mar 31, 2022 · 0998b0e · 0998b0e
1 parent 2767a51
commit 0998b0e
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/errgroup.go b/errgroup.go
@@ -154,13 +154,20 @@ func (g *Group) Go(f func() error) {
 		return
 	}
 
-	g.qCh <- f
-
-	// Check if we can or should start a new goroutine?
-	g.maybeStartG()
+	for {
+		if g.err != nil {
+			g.qMu.Unlock()
+			return
+		}
 
-	g.qMu.Unlock()
+		select {
+		case g.qCh <- f:
+			g.maybeStartG()
+			g.qMu.Unlock()
+			return
+		}
 
+	}
 }
 
 // maybeStartG might start a new worker goroutine, if