This repository was archived by the owner on Jun 19, 2020. It is now read-only.
adjust to mypy one based column offset #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy has changed to one based offsets as of: python/mypy#4475
|
Thanks for this, Padraig. I will look at the unrelated failure in a bit and we'll merge this. |
Open
|
Thanks! ✨ 🍰 ✨ |
|
🙄 I don't think this is a good PR. The tests are end-to-end, so if they break we have to fix the implementation not the test. I did this in #19. flake8 expects that we report 0-based columns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy has changed to one based offsets as of:
python/mypy#4475