ci(node): remove eol node versions

americanexpress · Jan 7, 2025 · 1e9fff0 · 1e9fff0
1 parent 2d19ea9
commit 1e9fff0
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 7 deletions.
diff --git a/.github/workflows/health-check.yml b/.github/workflows/health-check.yml
@@ -9,7 +9,7 @@ jobs:
   tests:
     strategy:
       matrix:
-        node: [ '14.x', '16.x', '18.x', '20.x', '22.x' ]
+        node: [ '18.x', '20.x', '22.x' ]
         os: [ ubuntu-latest, windows-latest, macos-latest ]
     runs-on: ${{ matrix.os }}
     name: Node ${{ matrix.node }} - ${{ matrix.os }}

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -9,7 +9,7 @@ jobs:
   tests:
     strategy:
       matrix:
-        node: [ '14.x', '16.x', '18.x', '20.x', '22.x' ]
+        node: [ '18.x', '20.x', '22.x' ]
         os: [ ubuntu-latest, windows-latest, macos-latest ]
     runs-on: ${{ matrix.os }}
     name: Node ${{ matrix.node }} - ${{ matrix.os }}

diff --git a/...image-snapshot-failures-writes-a-result-image-for-failing-tests-ssim-3-snap.png b/...image-snapshot-failures-writes-a-result-image-for-failing-tests-ssim-3-snap.png
diff --git a/__tests__/outdated-snapshot-reporter.spec.js b/__tests__/outdated-snapshot-reporter.spec.js
@@ -57,6 +57,18 @@ describe('OutdatedSnapshotReporter', () => {
   }
 
   function runJest(cliArgs, environment = {}) {
+    const ls = childProcess.spawnSync('ls', ['-la'], {
+      cwd: tmpDir,
+      encoding: 'utf-8',
+      env: { ...process.env, ...environment },
+    });
+    console.log(ls);
+    const ls2 = childProcess.spawnSync('ls', ['-la', path.join(jestImageSnapshotDir, 'node_modules/.bin/')], {
+      cwd: tmpDir,
+      encoding: 'utf-8',
+      env: { ...process.env, ...environment },
+    });
+    console.log(ls2);
     const child = childProcess.spawnSync(jestBinPath, cliArgs, {
       cwd: tmpDir,
       encoding: 'utf-8',

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -53,7 +53,7 @@
     "eslint-config-amex": "^7.0.0",
     "husky": "^4.2.1",
     "image-size": "^0.8.3",
-    "jest": "^29.0.0",
+    "jest": "^29.7.0",
     "jest-snapshot": "^29.0.0",
     "lockfile-lint": "^4.14.0",
     "mock-spawn": "^0.2.6",
@@ -106,9 +106,9 @@
       "@semantic-release/git",
       "@semantic-release/github"
     ]
-  }, 
+  },
   "overrides": {
-    "eslint-config-amex" : {
+    "eslint-config-amex": {
       "eslint": "$eslint"
     }
   }