fix(_sqlalchemy): type object SQLAlchemy.Base has no attribute 'model_fields' #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
SqlalchemyCrud.on_update_pre
usesmodel_fields
function for both PyDantic.BaseModel and SQLAlchemy.Base, but the last has no attributemodel_fields
Steps to reproduce
deleted_at=null
How to fix
To fix this issue, we should check if self.model is SQLAlchemy model If so, then we should use
__pydantic_model__
formodel_fields
, otherwise just passself.model