Modernisation 1 - Formating Only #798
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents comprehensive plan for introducing Biome formatter with: - Node.js v16 engine requirement update - Biome installation and configuration - Staged formatting rollout (lib/ first, then all files) - Test suite validation at each stage - Lefthook pre-commit hooks for automated formatting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update Node.js engine requirement from >=10 to >=16 - Add @biomejs/biome as development dependency with strict formatting rules - Configure Biome with 2-space indents, 140-char lines, single quotes, trailing commas - Install Lefthook for automated pre-commit formatting hooks - Add npm format script for manual code formatting - Format entire codebase (63 files) with consistent styling - Update changelog for v1.0.0 major release - All tests pass with formatted code 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
kibertoad
approved these changes
Sep 3, 2025
|
Thanks for the review @kibertoad. I'm going progress with the linting PRs and merge sequentially when they are all done |
cressie176
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a series of pull requests aimed at modernising the amqplib code base, which will eventually mean amqplib is only compatible with Node v16 and above.
This change formats the codebase using biome (oxlint's formatter didn't support indent). Lefthook was configured to re-format on commit, and a "format" script was added to package.json
No other listing or changes were made.