Modernisation 5 - Replace all var declarations with let/const for modern JavaScript sta… #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndards - Replace 674 var declarations with appropriate let/const - Use const for immutable values (requires, constants, never-reassigned variables) - Use let for variables that get reassigned (loop counters, mutated state) - Modernise codebase for Node.js v18+ with proper block scoping - Eliminate variable hoisting issues and improve code clarity - All tests pass with zero linting errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
kibertoad
approved these changes
Sep 4, 2025
The var to let/const modernisation resolved all noInnerDeclarations violations by moving variable declarations to proper block scope with let/const. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The var to let/const modernisation resolved all noInvalidUseBeforeDeclaration violations by eliminating variable hoisting issues with proper block scoping. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Killed 3 birds (noVar, noInnerDeclarations, noInvalidUseBeforeDeclaration) with one stone
🤖 Generated with Claude Code