drivers: dac: ad3530r: Add driver support for Ad3530R #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaikiranGudla
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
Add header and source files for AD3530R driver. Signed-off-by: SGudla <Saikiran.Gudla@analog.com>
SaikiranGudla
force-pushed
the
ad3530r_support
branch
from
9897b2e to
3008d06
Compare
| @@ -0,0 +1,1093 @@ | |||
| /**************************************************************************//** | |||
There was a problem hiding this comment.
Use the BSD 3 clause license instead (e.g https://github.com/analogdevicesinc/no-OS/blob/main/include/no_os_aout.h#L1).
Comment on lines
+74
to
+77
| /******************************************************************************/ | ||
| /************************ Functions Definitions *******************************/ | ||
| /******************************************************************************/ | ||
| /******************************************************************************/ |
There was a problem hiding this comment.
You can remove these comments. They don't add too much and just take screen space.
Comment on lines
+69
to
+72
| .single_instr = 0, // Sets the streaming mode. | ||
| .stream_length_keep_value = 1 // Prevents the stream length value from | ||
| // automatically resetting to zero. | ||
| }; |
There was a problem hiding this comment.
Use the /**/ comment style
Comment on lines
+58
to
+63
| #define AD3530R_DATA_INDEX(x) x ? 1 : 2 | ||
| #define AD3530R_INSTR_LEN(x) AD3530R_DATA_INDEX(x) | ||
| #define AD3530R_ADDR_INDEX(x) x ? 0 : 1 | ||
| #define AD3530R_BUFF_LEN(x) x ? 2 : 3 | ||
| #define AD3530R_CRC_BUFF_LEN(x) x ? 3 : 4 | ||
| #define AD3530R_CRC_INDEX(x) AD3530R_ADDR_INDEX(x) + 2 |
There was a problem hiding this comment.
Add parentheses around x
| AD3530R_REG_ADDR_INTERFACE_CONFIG_A, | ||
| AD3530R_MASK_ADDR_ASCENSION, | ||
| cfg->addr_asc); | ||
| if (NO_OS_IS_ERR_VALUE(ret)) |
There was a problem hiding this comment.
We don't really use NO_OS_IS_ERR_VALUE() for these cases anymore. If your functions only return negative error codes, use this instead:
if (ret)
return ret;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add header and source files for AD3530R driver.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist