Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build documentation #1641

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

JJuanill
Copy link

Changes

CMakeLists.txt
Added post-build in CMake to copy .DLL files in build directory for launching and debugging Scopy in Windows

cmakelists_template.mako
Adjusted CMakeLists template for plugins to output generated libraries in plugins directory

Added

local-windows-build-readme.md
Documented build process for local Windows environment

@adisuciu adisuciu requested a review from bindea-cristian May 30, 2024 10:55
@bindea-cristian
Copy link
Contributor

Hi @JJuanill, I'll look into your PR in the following days

Copy link
Contributor

@bindea-cristian bindea-cristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good documentation, good description of the workflow, a good how to get started on Scopy development.
Just few hardcoded things that can be resolved, I think a tutorial should be more generic.
And a few misunderstandings about what commands are used when creating a docker image and what commands are used in practice.
Overall good job.

CMakeLists.txt Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
doc/local-windows-build-readme.md Outdated Show resolved Hide resolved
@bindea-cristian
Copy link
Contributor

And also, thank you very much for your contribution to the project! :D

@JJuanill
Copy link
Author

JJuanill commented Jun 5, 2024

And also, thank you very much for your contribution to the project! :D

Thank you too for the valuable feedback. I'll be working on these changes you raised. 😊

@JJuanill JJuanill marked this pull request as draft July 12, 2024 01:06
@JJuanill JJuanill changed the title Windows local build changes and new documentation Windows build documentation Jul 12, 2024
Copy link
Author

@JJuanill JJuanill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted code changes and revised build documentation

@JJuanill JJuanill marked this pull request as ready for review July 12, 2024 01:25
@JJuanill JJuanill force-pushed the dev_windows_build branch 5 times, most recently from ed80c33 to b6fdaf4 Compare August 7, 2024 01:57
…ironment

Signed-off-by: John Lloyd Juanillo <Johnlloyd.Juanillo@analog.com>
@JJuanill JJuanill force-pushed the dev_windows_build branch from df66984 to a2de5f7 Compare August 7, 2024 02:13
@bindea-cristian bindea-cristian merged commit 3e19c23 into analogdevicesinc:dev Aug 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants