Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci automated js ctests #1660

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Ci automated js ctests #1660

merged 8 commits into from
Aug 9, 2024

Conversation

IonutMuthi
Copy link
Contributor

No description provided.

@IonutMuthi IonutMuthi force-pushed the ci_automated_js_ctests branch from 3d98fbc to ba7bf9d Compare July 11, 2024 05:23
@IonutMuthi IonutMuthi force-pushed the ci_automated_js_ctests branch from b961327 to ec9b6da Compare July 23, 2024 13:16
@IonutMuthi IonutMuthi marked this pull request as ready for review July 24, 2024 04:31
adisuciu
adisuciu requested changes Jul 24, 2024
View reviewed changes
JS/scopyDefaultTests.js Outdated Show resolved Hide resolved
JS/scopyDefaultTests.js Outdated Show resolved Hide resolved
JS/scpyDefaultJsFunctions.js Outdated Show resolved Hide resolved
pluginbase/src/scopyjs.cpp Outdated Show resolved Hide resolved
@IonutMuthi
pluginbase: scopy api add function for running a list of scripts
236f434 
command from cmd is :
 ./scopy -S={"script1","script2",...}
or
 ./scopy -S "script1" -S "script2"...

Signed-off-by: Ionut Muthi <ionut.muthi@analog.com>
@IonutMuthi
pluginbase: import file to JS
e1afb6f 
Signed-off-by: Ionut Muthi <ionut.muthi@analog.com>
@IonutMuthi
ci/tests: scopy first test
1c15fd6 
Signed-off-by: Ionut Muthi <ionut.muthi@analog.com>
@IonutMuthi IonutMuthi force-pushed the ci_automated_js_ctests branch from ec9b6da to 522236d Compare July 25, 2024 06:26
@IonutMuthi
ci/tests: datalogger test
0e478a7 
Signed-off-by: Ionut Muthi <ionut.muthi@analog.com>
@IonutMuthi
ci/tests: run test offscreen
d93a956 
Signed-off-by: Ionut Muthi <ionut.muthi@analog.com>
@IonutMuthi IonutMuthi force-pushed the ci_automated_js_ctests branch 4 times, most recently from 6ad7fa7 to 897b511 Compare July 25, 2024 06:46
@IonutMuthi
ci/tests: added CMAKE option to turn ON/OFF JS automated tests
310581b 
Signed-off-by: Ionut Muthi <ionut.muthi@analog.com>
@IonutMuthi IonutMuthi force-pushed the ci_automated_js_ctests branch from 897b511 to 310581b Compare July 25, 2024 07:00
adisuciu
adisuciu requested changes Aug 6, 2024
View reviewed changes
js/scpycommon.js Outdated Show resolved Hide resolved
AlexandraTrifan
AlexandraTrifan reviewed Aug 6, 2024
View reviewed changes
js/test.sh Outdated Show resolved Hide resolved
Andrei-Fabian-Pop
Andrei-Fabian-Pop reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Andrei-Fabian-Pop Andrei-Fabian-Pop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check the indentation in the js and bash scripts, there are some misaligned rows and extra spaces

plugins/datalogger/js/dataLoggerAutomatedTest.js Outdated Show resolved Hide resolved
@IonutMuthi
fixup: js test typos
60d29e0 
Signed-off-by: IonutMuthi <ionut.muthi@analog.com>
@IonutMuthi
fixup: datalogger tests typos
9a43163 
Signed-off-by: IonutMuthi <ionut.muthi@analog.com>
@IonutMuthi IonutMuthi force-pushed the ci_automated_js_ctests branch from 13b40fb to 9a43163 Compare August 7, 2024 06:19
@IonutMuthi IonutMuthi requested a review from adisuciu August 7, 2024 07:27
@adisuciu adisuciu merged commit fbd3160 into dev Aug 9, 2024
22 checks passed
@adisuciu adisuciu deleted the ci_automated_js_ctests branch August 9, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreidanila1 andreidanila1 Awaiting requested review from andreidanila1

@bindea-cristian bindea-cristian Awaiting requested review from bindea-cristian

@AlexandraTrifan AlexandraTrifan Awaiting requested review from AlexandraTrifan

@Andrei-Fabian-Pop Andrei-Fabian-Pop Awaiting requested review from Andrei-Fabian-Pop

@adisuciu adisuciu Awaiting requested review from adisuciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IonutMuthi @adisuciu @AlexandraTrifan @Andrei-Fabian-Pop