Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namadillo: Refactoring Unbonding and Withdraw, moving them to MyValidator type #1037

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

pedrorezende
Copy link
Collaborator

This PR refactors all the withdraw and unbonding data to be available inside MyValidator type. This will also fix #1023 .

@pedrorezende pedrorezende marked this pull request as draft August 21, 2024 21:43
@pedrorezende pedrorezende force-pushed the feat/namadillo/unbonding-wheel-colors branch from 3d672c8 to 5212342 Compare August 21, 2024 21:53
@pedrorezende pedrorezende force-pushed the feat/namadillo/unbonding-wheel-colors branch from 5212342 to 2381933 Compare August 21, 2024 22:03
@pedrorezende pedrorezende marked this pull request as ready for review August 21, 2024 22:05
@pedrorezende pedrorezende changed the title refactor: moving withdraw and unbonding to MyValidator correctly Namadillo: Refactoring Unbonding and Withdraw, moving them to MyValidator type Aug 21, 2024
Copy link
Collaborator

@euharrison euharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏

I'm still a little bit confused by the names

And if we should split the concept of unbonding and withdrawable on atom, or if it should be only on the table component

Maybe it could be clear after we merge the PR 🚀

apps/namadillo/src/App/Staking/StakingOverview.tsx Outdated Show resolved Hide resolved
apps/namadillo/src/App/Staking/UnbondingAmountsTable.tsx Outdated Show resolved Hide resolved
apps/namadillo/src/App/Staking/UnbondingAmountsTable.tsx Outdated Show resolved Hide resolved
apps/namadillo/src/types.d.ts Outdated Show resolved Hide resolved
apps/namadillo/src/App/Staking/WithdrawalButton.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrorezende pedrorezende merged commit cf5ce7c into main Aug 28, 2024
8 checks passed
@mateuszjasiuk mateuszjasiuk deleted the feat/namadillo/unbonding-wheel-colors branch September 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Unbonding NAMs to the wheel
3 participants