Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch shielded balances on transfer #1547

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

euharrison
Copy link
Collaborator

@euharrison euharrison commented Jan 15, 2025

This PR resolves most of the current issues related to the shielded balance

  • Re-run the shielded sync and the shielded balance after any successful transfer.
  • The balance is now saved on local storage and we can provide the last cached value
  • Added a shielded sync indicator on the sidebar that shows the percentage of the shielded sync on any Masp page and the Overview
  • Also, update the indicator text when the shielded sync is converting assets, which currently takes a longer time and we don't have a progress indicator on the sdk side
  • Fix the dollar value considering the NAM as zero until it's available on osmosis api.
  • Add a 2h timeout for transfers that do not completed and aren't available on chain for whatever reason

closes #1484
closes #1493
closes #1495
closes #1497
closes #1498

shield2.mp4

Copy link
Collaborator

@pedrorezende pedrorezende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvements! But I still feel we would need something better to handle the masp updates. Like an optmistic updates. I'll think of a solution too

@euharrison euharrison merged commit 61107fc into main Jan 15, 2025
7 checks passed
@euharrison euharrison deleted the feat/sync-balances-on-transfer branch January 15, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants