Skip to content

feat: Find and Fix Stitch Faces/Missing Faces Enhancements #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: Find and Fix Stitch Faces/Missing Faces Enhancements #1953

wants to merge 11 commits into from

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented May 1, 2025 •
edited
Loading

Description

added model for testing stitching many faces
added find_and_fix_stitch_faces
added applicable tests (comprehensive and standard)

Issue linked

#1947
#1949
#1950

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

added model for testing stitching many faces
38ba56a 
added find_and_fix_stitch_faces
added applicable tests (comprehensive and standard)
@jacobrkerstetter jacobrkerstetter self-assigned this May 1, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner May 1, 2025 15:33
@github-actions github-actions bot added the enhancement New features or code improvements label May 1, 2025
This was linked to issues May 1, 2025
find_fix_stitch_faces #1947
Open
find_stitch_faces should have a maximum distance #1950
Open
@jacobrkerstetter jacobrkerstetter marked this pull request as draft May 1, 2025 17:47
@jacobrkerstetter jacobrkerstetter linked an issue May 1, 2025 that may be closed by this pull request
find_missing_faces should have an angle and distance input #1949
Open
@jacobrkerstetter jacobrkerstetter changed the title feat: Find and Fix Stitch Faces Repair Tool feat: Find and Fix Stitch Faces/Missing Faces Enhancements May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

@RyanJWard RyanJWard Awaiting requested review from RyanJWard

At least 1 approving review is required to merge this pull request.

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
2 participants
@jacobrkerstetter @pyansys-ci-bot