-
Notifications
You must be signed in to change notification settings - Fork 140
ci: adding docker compose files for testing #4186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…cker files to `MAPDL` directory.
…e, docker-compose, and start script
…ved configurations and profiles
…e commented profiles
…ration and remove unnecessary dependencies
…gurations and added mylocal.ip
…r PyMAPDL testing setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Docker Compose files for testing PyMAPDL against different MAPDL installations. The goal is to simplify testing configuration by providing containerized environments with various profile combinations for running tests locally or against remote MAPDL instances.
Key changes include:
- Addition of a comprehensive Docker Compose configuration with multiple profiles for different testing scenarios
- Creation of a flexible Dockerfile with multiple build targets for various testing configurations
- Addition of supporting scripts and configuration files for test execution
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
docker/testing/docker-compose.yml | Comprehensive Docker Compose configuration with multiple profiles for testing PyMAPDL against different MAPDL setups |
docker/testing/Dockerfile | Multi-stage Dockerfile with various build targets for different testing scenarios |
docker/testing/start.sh | Bash script for running tests with environment variable handling and branch switching |
docker/testing/mylocal.ip | Configuration file with localhost IP address for MAPDL |
docker/MAPDL/make_container.rst | Updated file paths to reflect new directory structure |
doc/source/getting_started/make_container.rst | Updated include path to point to reorganized documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4186 +/- ##
==========================================
- Coverage 91.31% 91.31% -0.01%
==========================================
Files 193 193
Lines 15724 15731 +7
==========================================
+ Hits 14358 14364 +6
- Misses 1366 1367 +1 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…moving duplicates
…nsys/pymapdl into ci/adding-pymapdl-docker-image
…irement in mapdl-remote-container
Description
As the title. The idea is to simplify the testing configuration.
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)