Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 19, 2025

Description

As the title. The idea is to simplify the testing configuration.

Issue linked

NA

Checklist

@Copilot Copilot AI review requested due to automatic review settings August 19, 2025 17:40
@germa89 germa89 requested a review from a team as a code owner August 19, 2025 17:40
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) labels Aug 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Docker Compose files for testing PyMAPDL against different MAPDL installations. The goal is to simplify testing configuration by providing containerized environments with various profile combinations for running tests locally or against remote MAPDL instances.

Key changes include:

  • Addition of a comprehensive Docker Compose configuration with multiple profiles for different testing scenarios
  • Creation of a flexible Dockerfile with multiple build targets for various testing configurations
  • Addition of supporting scripts and configuration files for test execution

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docker/testing/docker-compose.yml Comprehensive Docker Compose configuration with multiple profiles for testing PyMAPDL against different MAPDL setups
docker/testing/Dockerfile Multi-stage Dockerfile with various build targets for different testing scenarios
docker/testing/start.sh Bash script for running tests with environment variable handling and branch switching
docker/testing/mylocal.ip Configuration file with localhost IP address for MAPDL
docker/MAPDL/make_container.rst Updated file paths to reflect new directory structure
doc/source/getting_started/make_container.rst Updated include path to point to reorganized documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (de1cf18) to head (d3f1fc6).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4186      +/-   ##
==========================================
- Coverage   91.31%   91.31%   -0.01%     
==========================================
  Files         193      193              
  Lines       15724    15731       +7     
==========================================
+ Hits        14358    14364       +6     
- Misses       1366     1367       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants