Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriceChanger #20

Merged
merged 3 commits into from
Feb 24, 2024
Merged

PriceChanger #20

merged 3 commits into from
Feb 24, 2024

Conversation

ts0yu
Copy link
Collaborator

@ts0yu ts0yu commented Feb 24, 2024

closes #9

@ts0yu ts0yu marked this pull request as draft February 24, 2024 21:11
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean, we should be able to config the price path in the toml. That way you don't have to recompile every time you change parameters

@ts0yu ts0yu marked this pull request as ready for review February 24, 2024 21:24
@ts0yu ts0yu requested a review from Autoparallel February 24, 2024 21:24
src/behaviors/price_changer.rs Show resolved Hide resolved
#[derive(Serialize, Deserialize)]
pub struct PriceChanger {
#[serde(skip)]
pub params: OrnsteinUhlenbeckParams,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we can make this generic and have a ProcessType trait. Then impl that on the different param types.


#[serde(skip)]
#[serde(default = "trajectory_default")]
pub current_chunk: Trajectories,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this name?

self.cursor = 0;
self.value = self.current_chunk.paths.clone()[0][self.cursor];
self.current_chunk =
ou.euler_maruyama(self.value, 0.0, 100.0, 100_usize, 1_usize, false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use seedable

@ts0yu ts0yu merged commit 0169e16 into main Feb 24, 2024
4 checks passed
@Autoparallel Autoparallel deleted the z/changer branch February 24, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Price updater behavior
3 participants