Skip to content

docs: add documentation for expr function expression support #6735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025

Conversation

BQXBQX
Copy link
Contributor

@BQXBQX BQXBQX commented Apr 2, 2025

Checklist
  • commit message follows commit guidelines
  • documents are updated
Description of change

Sorry, something went wrong.

@hustcc hustcc requested a review from interstellarmt April 2, 2025 09:14
@BQXBQX
Copy link
Contributor Author

BQXBQX commented Apr 2, 2025

在我完善 demo 时,遇到了一个问题, attr 属性貌似无法使用 spec 传入,无论是单测的例子还是官网的例子,好像 attr 的调用方法都是 函数式 调用形式。而且官网的 函数式 -> spec 例子中,会把 attr 中定义的属性提取到父对象中。例如 https://g2.antv.antgroup.com/examples/composition/space#space-layer ,所以我们还需要支持 attr 吗?

@hustcc
Copy link
Member

hustcc commented Apr 2, 2025

在我完善 demo 时,遇到了一个问题, attr 属性貌似无法使用 spec 传入,无论是单测的例子还是官网的例子,好像 attr 的调用方法都是 函数式 调用形式。而且官网的 函数式 -> spec 例子中,会把 attr 中定义的属性提取到父对象中。例如 https://g2.antv.antgroup.com/examples/composition/space#space-layer ,所以我们还需要支持 attr 吗?

算是一个 bug,那就先移除支持吧,记得文档也修改一下。

@coveralls
Copy link

coveralls commented Apr 2, 2025

Pull Request Test Coverage Report for Build 14235348496

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.768%

Totals Coverage Status
Change from base Build 14211352360: 0.0%
Covered Lines: 10733
Relevant Lines: 11989

💛 - Coveralls

@hustcc hustcc merged commit 78a9fc5 into antvis:v5 Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants