fix: release healthchecker on 0 nodes #12126
Merged
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
nic-chen
reviewed
Apr 9, 2025
apisix/upstream.lua
Outdated
| @@ -327,6 +327,9 @@ function _M.set_by_route(route, api_ctx) | |||
|
|
|||
| local nodes_count = up_conf.nodes and #up_conf.nodes or 0 | |||
| if nodes_count == 0 then | |||
| if up_conf.parent and up_conf.parent.checker then | |||
There was a problem hiding this comment.
should check the parent and checker in function release_checker ?
There was a problem hiding this comment.
ok sounds right. done
nic-6443
reviewed
Apr 10, 2025
nic-6443
reviewed
Apr 10, 2025
nic-chen
approved these changes
Apr 10, 2025
membphis
approved these changes
Apr 11, 2025
nic-6443
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to this fix: #12118
The healthchecker should also be released when new node count is 0.
Checklist