-
Notifications
You must be signed in to change notification settings - Fork 5k
CAMEL-21945 camel-jbang: add edit plugin #17704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
New release with the required change available https://repo1.maven.org/maven2/com/github/camel-tooling/camel-lsp-server/1.31.0/ |
It would be a bit heavy to have all these dependencies in the core camel-jbang command. So I think it may be a good idea to move this into a new seperate plugin like we have for kubernetes etc. |
This looks cool, can you try to see if you can get this to work for yaml DSL also. |
Yeah yaml and properties file should work: For YAML the file has to end in camel.yaml or camel.yml though (camel-language-server). Let's add it as a plugin. We can then later trim the dependencies as the server stuff isn't needed. Thanks! |
Ok so I added it as a plugin called edit. I've renamed the old editor to nano to not conflict. Let me know what you think Thanks ! |
45281b6
to
af7ad7e
Compare
@davsclaus thanks for the review! All good on my side |
Description
https://issues.apache.org/jira/browse/CAMEL-21945
Adds camel-lsp to the Camel JBang text editor. This is largely based on JLine's Nano editor. Users could then benefit from suggestions and diagnostics while writing Camel routes. This should help users to write routes faster.
Needs camel-tooling/camel-language-server#1266
Thanks!
Target
main
branch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTests
locally from root folder and I have committed all auto-generated changes.