CAMEL-21845: camel-sql - Only commit/rollback if auto commit has been true

[graben]

Add-on to the optimization from CAMEL-21845. Commit or rollback should only be called if auto commit has not been set to false before. This might be intended to control the transaction for whatever reason! In cases of XA transactions, for example, calling commit or rollback would cause exceptions.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[zhfeng]

I wonder if there is any better way to check if we are running in a JTA transaction?

[zhfeng]

IIRC

Commit or rollback should only be called if auto commit has not been set to false before.

So it should check with if (manualCommit && restoreAutoCommit) ?

[graben]

Ups, seems your right. I'll change it.

[graben]

I wonder if there is any better way to check if we are running in a JTA transaction?

You're right that there are better ways to identify JTA, but it's only one option why a connection has been set to auto commit before calling sql producer.

[zhfeng]

@davsclaus can we use exchange.IsTransacted() ?

[zhfeng]

I think it should be true if sql is using in a transacted() like

from("direct:foo")
    .transacted()
    .to("sql:INSERT INTO ...");