Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clouseau): bump to 2.25.0 #5488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pgj
Copy link
Contributor

@pgj pgj commented Mar 25, 2025

We have had a couple of new Clouseau releases in the past few months. So catch up with them and use the latest version as both the default for the configure script and implicitly for the CI.

Testing recommendations

Other than exercising the change in the CI, one could manually verify it. Configure with Clouseau enabled (UNIX-like systems, including macOS) and be sure to have Java 8 on the path:

./configure --with-clouseau

or on Windows:

.\configure.ps1 -WithClouseau

Note that you may have to remove any older local installation of Clouseau before proceeding:

rm -rf clouseau

Run the Mango tests (implies using Clouseau):

make mango-test

Note that there shall be only a single skipped test in this scenario. Anything more than that may signal that Clouseau has not been fully configured.

Ran 389 tests in 40.212s

OK (skipped=1)

Run the Elixir search tests (implies using Clouseau):

make elixir-search

This should all work with Erlang/OTP 25, 26, and 27.

To verify if logging is still working, you can take a look at the contents of the dev/logs/clouseau1.log file after Clouseau has been started up alongside CouchDB, e.g.:

dev/run -a adm:pass -n 1 --with-clouseau

Checklist

  • Code is written and works correctly
  • Changes are covered by tests

We have had a couple of new Clouseau releases in the past few
months.  So catch up with them and use the latest version as both
the default for the `configure` script and implicitly for the CI.
@big-r81
Copy link
Contributor

big-r81 commented Mar 25, 2025

Hey Gábor, to run the full CI, you need a branch name starting with jenkins-... iirc...

@pgj
Copy link
Contributor Author

pgj commented Mar 25, 2025

Yes, you are right. That is my plan forward, but first I wanted to make sure that it passes the basic tests.

@pgj
Copy link
Contributor Author

pgj commented Mar 25, 2025

I see this for Windows:

[2025-03-25T10:36:18.253Z] <ERROR> get_cookie: can't open cookie fileerl_call: can't create C node c17@WIN-F71NFGBB2HR; 0
[2025-03-25T10:36:18.253Z] [ * ] Check Clouseau node clouseau1 ... failed: Command '['erl_call', '-n', 'node1@127.0.0.1', '-a', "net_adm ping ['clouseau1@127.0.0.1']"]' returned non-zero exit status 1.

Could this be an issue specific to the Windows builder?

@big-r81
Copy link
Contributor

big-r81 commented Mar 25, 2025

Is it possible that Clouseau isn't loaded at this stage, so that the "ping" failed?

How does Clouseau gets startet? We only have $env:CLOUSEAU_JAVA_HOME = "${toolsDir}\${java8Build}" as var to point to a jdk8. In the normal path, there is a Java21 linked, see bin/shell.ps1 and bin/variables.ps1

@pgj
Copy link
Contributor Author

pgj commented Mar 25, 2025

Is it possible that Clouseau isn't loaded at this stage, so that the "ping" failed?

I am not sure about that. To me, the error message above suggests that erl_call itself cannot establish connection to the Clouseau node because it was not able to create the missing Erlang cookie. For what it is worth, Clouseau always uses the HOME environment variable to determine the location of the cookie, but erl_call uses the combined value of the HOMEDRIVE and HOMEPATH on Windows.

How does Clouseau gets started? We only have $env:CLOUSEAU_JAVA_HOME = "${toolsDir}\${java8Build}" as var to point to a jdk8.

I believe that should be sufficient. This is out of my concern at the moment.

@pgj
Copy link
Contributor Author

pgj commented Mar 25, 2025

Fixing the CI for the FreeBSD, macOS, and Windows workers is getting more complicated. I will just drop those commits from the PR so we could just safely merge the bump itself.

@pgj pgj force-pushed the chore/clouseau/2.25.0 branch from 6e0e710 to 5d357e2 Compare March 25, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants