-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement user defined planner for extract #11215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this PR up from main to resolve some conflicts
Thanks again @xinlifoobar |
I just reset my branch with upstream main just now and I'm getting this in 4 of my tests:
Is there some required changes to supporting code to facilitate the changes in this issue? |
Adding this clause to the plan_to_sql.rs:roundtrip_expr() test showcases the issue:
|
The issue boils down to SqlToRel::new_with_options(..) not setting the planners. Unfortunately, I can't find a way to retrieve the list of planners set on the context to set them myself - I'll file a ticket for that shortly. |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Part of #11207 and closes #11220
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?