Prepare MSQ/Dart to execute QueryDefinitions planned upfront #17895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return query; | ||
| } | ||
|
|
||
| public String getId() |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
|
|
||
| public interface MSQTerminalStageSpecFactory | ||
| { | ||
| /** | ||
| * Creates a {@link TerminalStageSpec} which determines the final of a query. | ||
| */ | ||
| TerminalStageSpec createTerminalStageSpec(DruidQuery druidQuery, PlannerContext plannerContext); | ||
| TerminalStageSpec createTerminalStageSpec(PlannerContext plannerContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -236,17 +244,26 @@ | |||
|
|
|||
| // This flag is to ensure backward compatibility, as brokers are upgraded after indexers/middlemanagers. | |||
| nativeQueryContextOverrides.put(MultiStageQueryContext.WINDOW_FUNCTION_OPERATOR_TRANSFORMATION, true); | |||
| boolean isReindex = MSQControllerTask.isReplaceInputDataSourceTask(druidQuery.getQuery(), destination); | |||
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Comment on lines
+255
to
+256
| LegacyMSQSpec.builder() | ||
| .query(druidQuery==null?null:druidQuery.getQuery().withOverriddenContext(nativeQueryContextOverrides)) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to center the MSQ/Dart execution around the
QueryDefinition- and prepares for a possible future removal of theQueryobject from theMSQSpecobject.MSQSpectoLegacyMSQSpecMSQSpeccontainsQueryDefinitionMSQSpec; important exception is that the task retains the oldContext#makeQueryKitSpecto be a factory instead