Optimize the performance of the Shell CLI by reducing the length of t… #14065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he CLASSPATH * Excludes runtime dependencies of grails-shell * Only include dependencies of grails-shell in the final distribution, no sources, javadocs, ivy files Fixes apachegh-14029
|
|
|
Does this CLA have updated to the Apache CLA? |
|
@rainboyan There will be a few more days until this repo moves over to Apache. For this PR it will still be this CLA. |
|
I do not believe these failures are related to this PR, since the same errors are occurring on https://github.com/grails/grails-data-mapping/actions/runs/13812249283/job/38636345797?pr=1933 We will rerun CI on this PR, once that is resolved. |
jamesfredley
approved these changes
Mar 13, 2025
|
This resolved the issue and had noticeable performance improvement. |
matrei
added a commit
to matrei/grails-core
that referenced
this pull request
Apr 2, 2025
It seems dependency configuration excludes do not affect inherited dependencies. Related: apachegh-14065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he CLASSPATH
Fixes gh-14029