Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8634] Support schema on read in file group reader-based compaction and clustering in Spark #12586

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yihua
Copy link
Contributor

@yihua yihua commented Jan 7, 2025

Change Logs

This PR enables schema on read in file group reader-based compaction and clustering in Spark after #12510 makes the schema on read-related configs are propagated properly.

Impact

Removes limitation of file group reader-based compaction and clustering in Spark around schema on read.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Jan 7, 2025
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:XS PR with lines of changes in <= 10 labels Jan 7, 2025
Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests for schema on read w/ new FG reader? can you point me to those?

spark.sql(s"CALL run_clustering(table => '$tableName', op => 'schedule')")
spark.sql(s"CALL run_clustering(table => '$tableName', op => 'execute')")
val clusteringRows = spark.sql(s"CALL show_clustering('$tableName')").collect()
assertResult(1)(clusteringRows.length)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we assert data as well

@hudi-bot
Copy link

hudi-bot commented Jan 7, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants