Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8315] update SqlKeyGenerator#convertPartitionPathToSqlType to handle default_partition_path #12621

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karthick-de-25
Copy link

Change Logs

the issue is at SqlKeyGenerator#convertPartitionPathToSqlType
where the default HIVE_DEFAULT_PARTITION value is trying to be converted into Long/milli second.

update SqlKeyGenerator#convertPartitionPathToSqlType to handle default_partition_path

TODO:

  • add testcase for ts default_partition_path at TestSparkSqlWithTimestampKeyGenerator

Impact

partition_path for timestamp partition

Risk level (write none, low medium or high below)

low

Documentation Update

NA

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Jan 12, 2025
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS PR with lines of changes in <= 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants