Normalize User Input in Registration #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpablo-santos
requested changes
Feb 14, 2025
| // --- Minimal dummy implementations --- | ||
|
|
||
| // A very basic HttpServletRequest implementation supporting getParameter. | ||
| private static class DummyHttpServletRequest implements HttpServletRequest { |
There was a problem hiding this comment.
Both DummyHttpServletRequest and DummyContext should better be mocked using mockito
| @@ -292,10 +293,10 @@ public UserProfile parseProfile( final Context context ) { | |||
| String password = request.getParameter( PARAM_PASSWORD ); | |||
| String fullname = request.getParameter( PARAM_FULLNAME ); | |||
| String email = request.getParameter( PARAM_EMAIL ); | |||
| loginName = InputValidator.isBlank( loginName ) ? null : loginName; | |||
| loginName = InputValidator.isBlank( loginName ) ? null : loginName.trim(); | |||
There was a problem hiding this comment.
InputValidator.isBlank( loginName ) ? null : loginName.trim(); can be reduced to (commons-lang3)StringUtils.trim( loginName ), and same for the other two fields.
| @@ -64,6 +64,7 @@ Licensed to the Apache Software Foundation (ASF) under one | |||
| import java.security.Principal; | |||
| import java.text.MessageFormat; | |||
| import java.util.List; | |||
| import java.util.Locale; | |||
| @BeforeEach | ||
| public void setUp() throws Exception { | ||
| // Initialize a minimal test engine. | ||
| engine = new TestEngine(); |
There was a problem hiding this comment.
may be static fields, instantiated with something like:
private static TestEngine engine = TestEngine.build();
private static UserManager userManager = engine.getManager( DefaultUserManager.class );
so if not needed, we avoid instantiating them if/when adding new tests here
|
Hi @juanpablo-santos please to another pass. |
Trim extraneous whitespace from the loginname, fullname, and email fields in DefaultUserManager.parseProfile(). This change ensures that values such as "admin" and "admin " are treated uniformly. A new unit test (DefaultUserManagerTrimTest) has been added to verify the trimming logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of user input during registration by ensuring that extraneous
whitespaceis removed from key fields. Specifically, theDefaultUserManager.parseProfile()method now trims the loginname, fullname, and email fields so that entries like "admin" and "admin " are treated uniformly.