KAFKA-19090: Move DelayedFuture and DelayedFuturePurgatory to server module #19390
+279
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module Signed-off-by: PoAn Yang <payang@apache.org>
|
Failed test OffloadAndTxnConsumeFromLeaderTest#executeTieredStorageTest in CI is not related to this PR. |
|
Should these classes go to the |
…module Signed-off-by: PoAn Yang <payang@apache.org>
mimaison
reviewed
Apr 8, 2025
| import org.junit.jupiter.api.Assertions.{assertEquals, assertFalse, assertThrows, assertTrue} | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| import java.util.concurrent.{CompletableFuture, ExecutionException} | ||
| import java.util.concurrent.atomic.AtomicInteger | ||
| import scala.jdk.CollectionConverters.CollectionHasAsScala | ||
| import scala.jdk.CollectionConverters._ |
There was a problem hiding this comment.
Can we keep the explicit import?
| @@ -16,22 +16,22 @@ | |||
| */ | |||
| package integration.kafka.server | |||
There was a problem hiding this comment.
I think we should also convert and move this file to server
| */ | ||
| @Override | ||
| public void onComplete() { | ||
| List<CompletableFuture<T>> pendingFutures = futures.stream().filter(future -> !future.isDone()).collect(Collectors.toList()); |
There was a problem hiding this comment.
You can use toList() instead of collect(Collectors.toList())
| log.trace("All futures have been completed or have errors, completing the delayed operation"); | ||
| return forceComplete(); | ||
| } else { | ||
| log.trace(pending + " future still pending, not completing the delayed operation"); |
There was a problem hiding this comment.
Use templating {} instead of concatenation in Logger methods.
| 0, | ||
| TimeUnit.MILLISECONDS, | ||
| new LinkedBlockingQueue<>(), | ||
| new ThreadFactory() { |
There was a problem hiding this comment.
You can use a lambda to make the anonymous class a bit less verbose
| return new KafkaThread("DelayedExecutor-" + purgatoryName, r, true); | ||
| } | ||
| }); | ||
| this.purgatoryKey = new DelayedOperationKey() { |
| DelayedFuture<T> delayedFuture = new DelayedFuture<>(timeoutMs, futures, responseCallback); | ||
| boolean done = purgatory.tryCompleteElseWatch(delayedFuture, List.of(purgatoryKey)); | ||
| if (!done) { | ||
| BiConsumer<Void, Throwable> callbackAction = new BiConsumer<>() { |
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
|
@mimaison Thanks for the review. I address all comments. |
mimaison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite these classes in Java and move them to the server module
Reviewers: Mickael Maison mickael.maison@gmail.com