KAFKA-14523: Decouple RemoteLogManager and Partition #19391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
|
After that the last remaining piece of work before being able to move the |
FrankYang0529
approved these changes
Apr 7, 2025
| /** | ||
| * Interface to decouple RemoteLogManager and Partition | ||
| */ | ||
| public interface TopicPartitionLog { |
There was a problem hiding this comment.
Will this interface be removed after we migrate all code out of core module?
There was a problem hiding this comment.
To be honest I don't know at the moment. It depends where Partition ends up going but there's still a lot of work to do before we can move it, so I think we'll need this interface for a little while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the last dependency in the core module.