Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Small cleanups in server tests #19395

Merged
merged 3 commits into from
Apr 8, 2025
Merged

MINOR: Small cleanups in server tests #19395

merged 3 commits into from
Apr 8, 2025

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Apr 6, 2025 •
edited by github-actions bot
Loading

  • Used List/Map/Set.of() for immutable collections
  • Reduced code duplication
  • Fixed IDEA code inspection warnings

Reviewers: Mickael Maison mickael.maison@gmail.com

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) labels Apr 6, 2025
@wernerdv
Copy link
Contributor Author

wernerdv commented Apr 6, 2025

@chia7712 Please review this small PR when you get a chance.

mimaison
mimaison reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I left a suggestion

server/src/test/java/org/apache/kafka/network/SocketServerConfigsTest.java Outdated
@@ -22,8 +22,8 @@

import org.junit.jupiter.api.Test;

import java.util.Arrays;
import java.util.HashMap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also replace the 2 usages of new HashMap<>() with Map.of()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions github-actions bot removed the triage PRs from the community label Apr 8, 2025
mimaison
mimaison approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mimaison mimaison changed the title MINOR: Small cleanups in server's tests MINOR: Small cleanups in server tests Apr 8, 2025
@mimaison mimaison merged commit 6c2af5f into apache:trunk Apr 8, 2025
25 checks passed
@wernerdv wernerdv deleted the cleanup_server_tests branch April 8, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimaison mimaison mimaison approved these changes

Assignees
No one assigned
Labels
ci-approved core Kafka Broker tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wernerdv @mimaison @frankvicky