KAFKA-18894: Add KIP-877 support for ConfigProvider #19397
Conversation
github-actions
bot
added
triage
|
Thanks for this patch, please use |
| * returns a map of config provider name and its instance wrapped in a {@link org.apache.kafka.common.internals.Plugin}. | ||
| * | ||
| * @param indirectConfigs The map of potential variable configs | ||
| * @param providerConfigProperties The map of config provider configs | ||
| * @param classNameFilter Filter for config provider class names | ||
| * @return map of config provider name and its instance. | ||
| * @return map of config provider name and its instance wrapped in a {@link org.apache.kafka.common.internals.Plugin}. |
There was a problem hiding this comment.
We could keep the original document, FYI #19050 (comment)
There was a problem hiding this comment.
Sure. I'll update all of them later.
| for (Map.Entry<String, String> entry : providerMap.entrySet()) { | ||
| try { | ||
| String prefix = CONFIG_PROVIDERS_CONFIG + "." + entry.getKey() + CONFIG_PROVIDERS_PARAM; | ||
| Map<String, ?> configProperties = configProviderProperties(prefix, providerConfigProperties); | ||
| ConfigProvider provider = Utils.newInstance(entry.getValue(), ConfigProvider.class); | ||
| provider.configure(configProperties); | ||
| configProviderInstances.put(entry.getKey(), provider); | ||
| Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG); |
There was a problem hiding this comment.
I don't think we need to wrap provider into a Plugin at this point, since the metrics are null and it doesn't seem to serve any practical purpose.
There was a problem hiding this comment.
This change is for ConfigTransformer#transform, so we need to update the path where the transform method is used.
| CONFIG_PROVIDERS_CONFIG + "." + name, | ||
| Plugins.ClassLoaderUsage.PLUGINS | ||
| name, | ||
| Plugins.ClassLoaderUsage.PLUGINS, | ||
| null |
There was a problem hiding this comment.
ditto: I don't think we need to wrap provider into a Plugin at this point, since the metrics are null and it doesn't seem to serve any practical purpose.
| for (Map.Entry<String, String> entry : providerMap.entrySet()) { | ||
| try { | ||
| String prefix = CONFIG_PROVIDERS_CONFIG + "." + entry.getKey() + CONFIG_PROVIDERS_PARAM; | ||
| Map<String, ?> configProperties = configProviderProperties(prefix, providerConfigProperties); | ||
| ConfigProvider provider = Utils.newInstance(entry.getValue(), ConfigProvider.class); | ||
| provider.configure(configProperties); | ||
| configProviderInstances.put(entry.getKey(), provider); | ||
| Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG); |
There was a problem hiding this comment.
This change is for ConfigTransformer#transform, so we need to update the path where the transform method is used.
| CONFIG_PROVIDERS_CONFIG + "." + name, | ||
| Plugins.ClassLoaderUsage.PLUGINS | ||
| name, | ||
| Plugins.ClassLoaderUsage.PLUGINS, | ||
| null |
| * returns a map of config provider name and its instance wrapped in a {@link org.apache.kafka.common.internals.Plugin}. | ||
| * | ||
| * @param indirectConfigs The map of potential variable configs | ||
| * @param providerConfigProperties The map of config provider configs | ||
| * @param classNameFilter Filter for config provider class names | ||
| * @return map of config provider name and its instance. | ||
| * @return map of config provider name and its instance wrapped in a {@link org.apache.kafka.common.internals.Plugin}. |
There was a problem hiding this comment.
Sure. I'll update all of them later.
Add KIP-877 support for ConfigProvider.
Cleanup: Collections.singletonMap() -> Map.of()
Jira: https://issues.apache.org/jira/browse/KAFKA-18894