KAFKA-18913: Consider removing state-updater feature flag - 2 #20382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
reviewed
Aug 22, 2025
| @@ -204,7 +204,7 @@ public void initializeStartupTasks(final TopologyMetadata topologyMetadata, | |||
| if (hasPersistentStores && !nonEmptyTaskDirectories.isEmpty()) { | |||
| final ThreadCache dummyCache = new ThreadCache(logContext, 0, streamsMetrics); | |||
| final boolean eosEnabled = StreamsConfigUtils.eosEnabled(config); | |||
| final boolean stateUpdaterEnabled = StreamsConfig.InternalConfig.stateUpdaterEnabled(config.originals()); | |||
There was a problem hiding this comment.
It seems we pass this into ProcessorStateManager only -- let's move the variable, and hardcode true for now.
mjsax
reviewed
Aug 22, 2025
| @@ -236,7 +235,7 @@ public StoreChangelogReader(final Time time, | |||
| this.stateRestoreListener = stateRestoreListener; | |||
| this.standbyUpdateListener = standbyUpdateListener; | |||
|
|
|||
| this.stateUpdaterEnabled = InternalConfig.stateUpdaterEnabled(config.originals()); | |||
There was a problem hiding this comment.
I think we only use this in one place, and it should be possible to remove the variable (and it's usage) completely, in one go
mjsax
reviewed
Aug 22, 2025
| @@ -393,7 +393,7 @@ public static StreamThread create(final TopologyMetadata topologyMetadata, | |||
| final Runnable shutdownErrorHook, | |||
| final BiConsumer<Throwable, Boolean> streamsUncaughtExceptionHandler) { | |||
|
|
|||
| final boolean stateUpdaterEnabled = InternalConfig.stateUpdaterEnabled(config.originals()); | |||
There was a problem hiding this comment.
This class is more complex. Might be better to split into a different PR, as it required more cleanup. Doing a partial cleanup for a single class, is not a "clean cut" and make reviewing more complex.
mjsax
reviewed
Aug 22, 2025
| @@ -416,6 +417,7 @@ public void shouldPollWithRightTimeoutWithStateUpdater(final Task.TaskType type) | |||
| shouldPollWithRightTimeout(true, type); | |||
| } | |||
|
|
|||
| @Disabled | |||
There was a problem hiding this comment.
I would not disable this test, but rather clean it up directly. Or exclude StoreChangelogReader from this PR.
|
\cc @lucasbru |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR-2 to incrementally remove old code and builds upon #20378
Changes Made:
ActiveTaskCreatorandStandbyTaskCreatorChecklist