MINOR: Cleanup Connect Module (5/n) #20393
Conversation
|
Adding @chia7712 as he has been helping with tonnes of reviews in this area. |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConfigInfos.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConfigKeyInfo.java
Outdated
Show resolved
Hide resolved
...ct/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConfigValueInfo.java
Outdated
Show resolved
Hide resolved
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java
Outdated
Show resolved
Hide resolved
| ", version='" + version + '\'' + | ||
| '}'; | ||
| @JsonProperty("type") | ||
| public PluginType type() { |
There was a problem hiding this comment.
Should it change the type from PluginType to String?
There was a problem hiding this comment.
I kept it as a PluginType as type is that. If we change it to String, we will have to confirm all uses of the same.
There was a problem hiding this comment.
Excuse me, the overrided version is totally same to the generated code, so is it necessary to override it?
There was a problem hiding this comment.
Ah sorry, I was reading the comment wrong. Yes indeed this code patch is unnecessary. I have updated the same.
Pls re-review!
| public boolean equals(Object obj) { | ||
| return PluginDesc.UNDEFINED_VERSION.equals(obj); | ||
| } | ||
|
|
||
| // Dummy hashCode method to not fail compilation because of equals() method |
There was a problem hiding this comment.
Could you please keep this comment? Otherwise, the implementation return super.hashCode(); look odd to me, since it's essentially identical to the default implementation
This PR aims at cleaning up the
connect:runtimemodule further by getting rid of some extra code which can be replaced by record and the relevant changes.