Skip to content

Expose metrics of engine startup permit state #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LennonChin
Copy link
Contributor

Why are the changes needed?

The metrics kyuubi_operation_state_LaunchEngine_* cannot reflect the state of Semaphore after configuring the maximum engine startup limit through kyuubi.server.limit.engine.startup, add some metrics to show the relevant permit state.

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

@LennonChin LennonChin force-pushed the engine_startup_metrics branch from 59246d6 to 483f44e Compare May 22, 2025 10:58
@LennonChin
Copy link
Contributor Author

@wForget cc

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (fc654cf) to head (483f44e).

Files with missing lines Patch % Lines
...g/apache/kyuubi/session/KyuubiSessionManager.scala 0.00% 7 Missing ⚠️
...a/org/apache/kyuubi/metrics/MetricsConstants.scala 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7072   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         697     697           
  Lines       43192   43203   +11     
  Branches     5854    5854           
======================================
- Misses      43192   43203   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants