Skip to content

Upgrade parent POM to version 44 and fix the checkstyle violations #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ndacyayisenga-droid
Copy link

@Ndacyayisenga-droid Ndacyayisenga-droid commented May 19, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

There is #200

Did you build / test your PR?

@Ndacyayisenga-droid
Copy link
Author

There is #200

Did you build / test your PR?

@slawekjaranowski there is a lot of checkstyle violations to refactor. I will push the next commit ASAP!

@Ndacyayisenga-droid Ndacyayisenga-droid changed the title Upgrade parent POM to version 44 Upgrade parent POM to version 44 and fix the checkstyle violations May 19, 2025
@Ndacyayisenga-droid
Copy link
Author

There is #200

Did you build / test your PR?

I updated the maven-parent to version 44 in this PR, which seems to have introduced stricter Checkstyle rules that were not enforced previously. This caused a large number of Checkstyle violations to surface when running mvn clean install, making the build fail.
To ensure a clean build, I addressed the following kinds of issues raised by Checkstyle:

1. Method name formatting: Methods like SHA1, SHA256, XX, etc., were flagged for not following the required lowerCamelCase convention.
2. Method length: Some test methods (e.g., ls, simple) exceeded the maximum allowed line count of 150.
3. Redundant modifiers: A few methods had redundant public modifiers within test classes.
4. Constant and variable naming: Identifiers like logger were flagged for not using uppercase with underscores for constants.
5. Unused local variables: Several tests in XmlServiceTest and others had unused variables that were flagged.
6. Visibility modifiers: Test class fields were flagged for not being private or not having accessor methods.

These changes were necessary just to get a successful build with the updated parent version.

cc @olamy

@slawekjaranowski
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants