Skip to content

[MWRAPPER-158] Remove incorrect license header #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbruun
Copy link

@lbruun lbruun commented May 22, 2025

The "This code is licensed to ASF" license header on the generated ./mvn/wrapper/maven-wrapper.properties file does not make sense. The file is the user's, not ASF's. It is generated as a convenience for the user.

The file is logically part of the user's own code. We don't know what license that has so adding a license header is bound to be wrong. Therefore removed completely.

I'm guessing the code comes from a time when the Plugin was only (meant to be) used internally in the Apache Maven
project. Then it would make sense.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • [x ] Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The "This code is licensed to ASF" license header on the generated
./mvn/wrapper/maven-wrapper.properties file does not make sense.
The file is the user's, not ASF's. It is generated as a convenience
for the user.

The file is logically part of the user's own code. We don't know
what license that has, so adding a license header is bound to be wrong.
@lbruun lbruun force-pushed the MWRAPPER-158-remove-incorrect-license-header branch from b1792c1 to fda8ab1 Compare May 22, 2025 09:39
@lbruun
Copy link
Author

lbruun commented May 22, 2025

CI pipeline currently blocked by MWRAPPER-159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant