[MNG-8677] Bump to Resolver 2.0.8 and more #2158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent un-interpolated artifact/dependency/local/remote repo enter Resolver, that treats all coordinates as opaque. --- TODO
|
Validator now catches same ITs as Mimir (due bug) in this PR #2176 |
cstamas
added a commit
that referenced
this pull request
Mar 27, 2025
…d un-interpolated (#2192) This PR contains @gnodet fix pulled out from #2158 and added a rudimentary and very ugly test. The original PR is unrelated, but did catch this "leak" of uniterpolated values. --- https://issues.apache.org/jira/browse/MNG-8629
|
One IT failure:
|
The test looks weird to me. The user settings contain a repository with a url containing a property substitution for which the value is defined in the pom properties. I think it would be ok if the property was defined as a Maven user property from CLI. I'd refactor the test to add a file and remove that property from the pom. As settings are interpolated, it seems to work. |
cstamas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to Resolver 2.0.8, changes:
Note: Requires Resolver 2.0.8 release.
https://issues.apache.org/jira/browse/MNG-8677