Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exposing non-public type outside its scope #2220

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Avoid exposing non-public type outside its scope #2220

merged 1 commit into from
Apr 5, 2025

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 2, 2025 •
edited
Loading

ValidationReportLevel isn't public so there shouldn't be a public constant with this type

@elharo elharo marked this pull request as ready for review April 3, 2025 11:22
@elharo elharo requested a review from gnodet April 3, 2025 11:22
@elharo elharo merged commit af82f7e into master Apr 5, 2025
20 checks passed
@elharo elharo deleted the public branch April 5, 2025 11:52
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet approved these changes

Assignees

@elharo elharo

Labels
maintenance
Projects
None yet
Milestone
4.0.0-rc-4
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @gnodet