Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded toString and valueOf calls #2230

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -839,8 +839,8 @@ public static void main(String... args) {

if (prev != null) {
int compare = prev.compareTo(c);
System.out.println(" " + prev.toString() + ' ' + ((compare == 0) ? "==" : ((compare < 0) ? "<" : ">"))
+ ' ' + version);
System.out.println(
" " + prev + ' ' + ((compare == 0) ? "==" : ((compare < 0) ? "<" : ">")) + ' ' + version);
}

System.out.println(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ private void writeLastUpdated(File touchfile, String key, String error) {
} catch (IOException e) {
getLogger()
.debug(
"Failed to record lastUpdated information for resolution.\nFile: "
+ touchfile.toString() + "; key: " + key,
"Failed to record lastUpdated information for resolution.\nFile: " + touchfile
+ "; key: " + key,
e);
} finally {
if (lock != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public void transferInitiated(TransferEvent event) {
message.append(darkOn).append(": ").append(resource.getRepositoryUrl());
message.append(darkOff).append(resource.getResourceName());

out.println(message.toString());
out.println(message);
}

@Override
Expand Down Expand Up @@ -243,6 +243,6 @@ public void transferSucceeded(TransferEvent event) {
}

message.append(')').append(darkOff);
out.println(message.toString());
out.println(message);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ public void error(CharSequence content, Throwable error) {

error.printStackTrace(pWriter);

System.err.println(
"[error] " + content.toString() + System.lineSeparator() + System.lineSeparator() + sWriter.toString());
System.err.println("[error] " + content + System.lineSeparator() + System.lineSeparator() + sWriter);
}

/**
Expand All @@ -121,7 +120,7 @@ public void error(Throwable error) {

error.printStackTrace(pWriter);

System.err.println("[error] " + sWriter.toString());
System.err.println("[error] " + sWriter);
}

/**
Expand Down Expand Up @@ -163,7 +162,7 @@ private void print(String prefix, Throwable error) {

error.printStackTrace(pWriter);

System.out.println("[" + prefix + "] " + sWriter.toString());
System.out.println("[" + prefix + "] " + sWriter);
}

private void print(String prefix, CharSequence content, Throwable error) {
Expand All @@ -172,7 +171,6 @@ private void print(String prefix, CharSequence content, Throwable error) {

error.printStackTrace(pWriter);

System.out.println("[" + prefix + "] " + content.toString() + System.lineSeparator() + System.lineSeparator()
+ sWriter.toString());
System.out.println("[" + prefix + "] " + content + System.lineSeparator() + System.lineSeparator() + sWriter);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public void transferInitiated(TransferEvent event) {
message.style(STYLE).append(": ").append(resource.getRepositoryUrl());
message.resetStyle().append(resource.getResourceName());

out.println(message.toString());
out.println(message);
}

@Override
Expand Down Expand Up @@ -93,6 +93,6 @@ public void transferSucceeded(TransferEvent event) {
}

message.append(')').resetStyle();
out.println(message.toString());
out.println(message);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ private String toString(Object obj) {
if (i > 0) {
buf.append(", ");
}
buf.append(String.valueOf(Array.get(obj, i)));
buf.append(Array.get(obj, i));
}
buf.append(']');
str = buf.toString();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public Map<String, ConditionParser.ExpressionFunction> registerFunctions(
if (!causeChain.isEmpty()) {
causeChain.append(" Caused by: ");
}
causeChain.append(cause.toString());
causeChain.append(cause);
cause = cause.getCause();
}
throw new RuntimeException(
Expand Down