try can use automatic resource management - all
#2395
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
can-use-automatic-resource-management-
branch
2 times, most recently
from
2b1a621 to
92c8a5e
Compare
Pankraz76
commented
May 27, 2025
...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java
Show resolved
Hide resolved
Pankraz76
force-pushed
the
can-use-automatic-resource-management-
branch
from
92c8a5e to
67c3363
Compare
Pankraz76
commented
May 27, 2025
There was a problem hiding this comment.
checked: https://docs.oracle.com/javase/8/docs/api/java/io/IOException.html
We shouldn’t write code like it’s an ATM—it’s confusing, mimics structure without real purpose, and avoids modern patterns. This approach trades boilerplate for actual business functionality.
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
Pankraz76
force-pushed
the
can-use-automatic-resource-management-
branch
2 times, most recently
from
e99e668 to
5355f71
Compare
Pankraz76
commented
May 27, 2025
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
elharo
reviewed
May 27, 2025
| @@ -78,22 +78,13 @@ protected void append(Object value) throws MojoExecutionException { | |||
| File file = getLogFile(); | |||
| getLog().info("[MAVEN-CORE-IT-LOG] Updating log file: " + file); | |||
There was a problem hiding this comment.
don't need all these log statements
There was a problem hiding this comment.
all all or just some, as partly addressed in enabler?
Pankraz76
changed the title
try can use automatic resource managementtry can use automatic resource management
|
might be flaky, as only one time and works on dev: 
kind of NPE everywhere. 
|
|
wait for enabler. |
Pankraz76
force-pushed
the
can-use-automatic-resource-management-
branch
from
5355f71 to
eec11b0
Compare
elharo
reviewed
May 28, 2025
Pankraz76
changed the title
try can use automatic resource managementtry can use automatic resource management - all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOcatch onmkdirs()#2396