Skip to content

NIFI-14191 Added the previous process group to the URL #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

homer-rich
Copy link
Contributor

@homer-rich homer-rich commented Apr 4, 2025

Added the previous process group to the end of the URL so that it may be centered with the click of the zoom button when navigating up a process group via the LeaveProcessGroup function.

Summary

NIFI-14191

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-14191
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-14191

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Tested using the hot reloading available via npm nx serve in the frontend folder.

Build

  • Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@mcgilman
Copy link
Contributor

Thanks for the PR @homer-rich! I'll have a look.

@mcgilman
Copy link
Contributor

I haven't had a chance to fully review, but I wanted to clarify the desired behavior. The current behavior of leave process group will navigate up one level and restore the users previous viewport. Here we are trying to retain that functionality but also select the child Process Group was just exited.

I have some concern at first glance (but I need to verify) that we're losing the centering behavior which would trigger when a user navigates to a selected component without having established a viewport to restore (like through a deep link).

@homer-rich
Copy link
Contributor Author

That is the correct interpretation of what I am trying to accomplish with the desired behavior. I was wondering if there was a way to respond differently if the link was deep vice using the Leave Group function. I'm new to JS/TS development, apologies in advance.

@mcgilman mcgilman added the new ui Pull requests for work relating to the new user interface being developed. label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants