Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Connector-V2] Fix postgres cdc with debezium_json format can not parse number without scale #9052

Open
wants to merge 38 commits into
base: dev
Choose a base branch
from

Conversation

FrommyMind
Copy link
Contributor

Purpose of this pull request

Fix #9037

Does this PR introduce any user-facing change?

No

How was this patch tested?

Updated E2E test cases.

Check list

@github-actions github-actions bot removed the api label Mar 27, 2025
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case with compatible_debezium_json format in

@github-actions github-actions bot added the CI&CD label Apr 5, 2025
This reverts commit dee56fb.
This reverts commit 0f27c4c.
@github-actions github-actions bot removed the CI&CD label Apr 5, 2025
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrommyMind for update and added test case!

Comment on lines +101 to +105
if (next.value() != null) {
reportMetrics(next);
processElement(next, collector, splitState);
markEnterPureIncrementPhase(next, splitState);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change necessary? cc @hailin0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that, the next is not null ,but next.value() maybe null when write data to kafka, so I change this.

@Hisoka-X Hisoka-X changed the title [Fix][Connector-V2][Postgres-CDC] BigDecimal cast String Exception [Fix][Connector-V2][Postgres-CDC] Fix postgres cdc with debezium_json format can not parse number without scale Apr 7, 2025
@Hisoka-X Hisoka-X changed the title [Fix][Connector-V2][Postgres-CDC] Fix postgres cdc with debezium_json format can not parse number without scale [Fix][Connector-V2] Fix postgres cdc with debezium_json format can not parse number without scale Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postgrescdc compatible_debezium_json当数据库字段类型有NUMERIC(24)这种报错
2 participants