-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Connector-V2] Fix postgres cdc with debezium_json format can not parse number without scale #9052
base: dev
Are you sure you want to change the base?
Conversation
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test case with compatible_debezium_json
format in
Line 81 in 44e54c7
public class PostgresCDCIT extends TestSuiteBase implements TestResource { |
...-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/postgres/PostgresCDCIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FrommyMind for update and added test case!
if (next.value() != null) { | ||
reportMetrics(next); | ||
processElement(next, collector, splitState); | ||
markEnterPureIncrementPhase(next, splitState); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change necessary? cc @hailin0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that, the next
is not null ,but next.value()
maybe null when write data to kafka, so I change this.
Purpose of this pull request
Fix #9037
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated E2E test cases.
Check list
New License Guide
release-note
.