[SPARK-50953][FOLLOW-UP] Allow whitespace/tab in variantGet paths #50484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhao-db
approved these changes
Apr 2, 2025
gene-db
approved these changes
Apr 4, 2025
cloud-fan
approved these changes
Apr 5, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 5, 2025
### What changes were proposed in this pull request? This PR allows for whitespaces to be used in variantGet paths. ### Why are the changes needed? JSON keys can have whitespaces and there needs to be a way to extract them. ### Does this PR introduce _any_ user-facing change? Yes, it allows for a more diverse set of variant_get paths. ### How was this patch tested? Unit tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes #50484 from harshmotw-db/harsh-motwani_data/variant_get_path. Authored-by: Harsh Motwani <harsh.motwani@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit ba7a537) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR allows for whitespaces to be used in variantGet paths.
Why are the changes needed?
JSON keys can have whitespaces and there needs to be a way to extract them.
Does this PR introduce any user-facing change?
Yes, it allows for a more diverse set of variant_get paths.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No