[SPARK-53388][SQL][TESTS] Split collations.sql
#52114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilicmarkodb
force-pushed
the
split_collations.sql
branch
2 times, most recently
from
2ccf969 to
a5d57ba
Compare
ilicmarkodb
force-pushed
the
split_collations.sql
branch
from
a5d57ba to
45d81f0
Compare
ilicmarkodb
changed the title
collations.sql
dongjoon-hyun
changed the title
collations.sqlcollations.sql
cloud-fan
approved these changes
Aug 27, 2025
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR, I propose splitting the
collations.sqlgolden file into smaller files, so that in the future we can create new golden files for different testing purposes related to collations, instead of putting everything into a single test file.Why are the changes needed?
Better testing.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.