Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bulk certify functionality to charts and dashboards #33002

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

vedantprajapati
Copy link
Contributor

@vedantprajapati vedantprajapati commented Apr 4, 2025

SUMMARY

This PR introduces the ability to bulk certify charts and dashboards. This feature allows users to apply certification information (certified by, certification details) to multiple resources simultaneously. Our company uses certification as a way to validate charts and dashboards before publishing. Being able to certify in bulk is very useful when users create many similar components (especially when you have thousands of charts and dashboards).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image image image

TESTING INSTRUCTIONS

Select multiple charts/dashboards using bulk select and certify them. users can only certify if they have the canEdit permission.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Readability Redundant Empty useEffect ▹ view ✅ Fix detected
Readability Use translation system for pluralization ▹ view ✅ Fix detected
Files scanned
File Path Reviewed
superset-frontend/src/features/bulkCertifyModal/BulkCertifyModal.tsx
superset-frontend/src/pages/DashboardList/index.tsx
superset-frontend/src/pages/ChartList/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Feedback and Support

@JZ6
Copy link
Contributor

JZ6 commented Apr 4, 2025

awesome!

@sadpandajoe
Copy link
Member

@kasiazjc to take a look at the ui change

@mistercrunch
Copy link
Member

Thanks for the PR - useful feature! And it's great to see that expanding the bulk-update functionality is pretty straightforward.

Thinking about UX/design - if/once we add a few extra bulk-action feature, it might make sense to refactor the buttons into an Action dropdown, but I think for now it's ok as is with just 3 buttons. Tagging @kasiazjc (designer) for input/feedback.

@vedantprajapati
Copy link
Contributor Author

@mistercrunch good point. On that note, at GEOTAB, we also have a separate bulk update owners feature as well. This was sought after from our users as a way to transfer ownership or to share their data for collaborating. We have them separate though because the bulk update owners has a few more checks we do on our end.

@mistercrunch
Copy link
Member

mistercrunch commented Apr 7, 2025

Right. Parameterized bulk actions probably brings us into slightly more complex design territories. Would involve dynamic controls based on the action that is selected. Could be good to have a mock of what that would look like.

Though from my perspective the current UX (as of this PR) is "ok for now".

@vedantprajapati
Copy link
Contributor Author

Could be good to have a mock of what that would look like.

Sure, let me see if i can make a separate PR for some other bulk functionalities we have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants