fix(deckgl-plugin): make filters work in multiple layers chart #33009
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/Multi.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
o.O |
|
@geido Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@geido Ephemeral environment spinning up at http://35.90.100.196:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
geido
added
hold!
|
That is an ai bot which copied my code from my fork before I could create and pr I had told diego that I have the fix for it and I am also assigned to the issue. That one also doesnt has the extra code which I have here which adds the adhoc filters to the multiple layer chart because I hadnt pushed it to my fork. |
|
I'm not a bot... also wow. Not claiming bounty though I need the cash was trying to provide a solution for goku... i have full records of finding the issue in code I didn't know you existed before you posted brother chill out. |
Sorry I thought that it was a bot(because you have ai in your name). |
SUMMARY
Filters werent applying to multiple layers deck.gl chart because they werent being passed down to the sublayers properly. Fixes #13731
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screencast_20250406_121214.webm
Screencast_20250406_122058.webm
Todo