Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdaptiveLayerNormModulation raises ValueError, instead of assert. #930

Merged
merged 1 commit into from
Jan 16, 2025
Merged

AdaptiveLayerNormModulation raises ValueError, instead of assert. #930

merged 1 commit into from
Jan 16, 2025
+2 −1

Conversation

ds-hwang
Copy link
Contributor

Wrong inputs should be user error, not internal logic errors.

@ds-hwang
AdaptiveLayerNormModulation raises ValueError, instead of assert.
705b466 
Wrong inputs should be user error, not internal logic errors.
@ds-hwang ds-hwang requested review from ruomingp, markblee and a team as code owners January 16, 2025 16:36
@ds-hwang ds-hwang enabled auto-merge January 16, 2025 16:36
@ds-hwang
Copy link
Contributor Author

Hi, could you take a look? From 981

@ds-hwang ds-hwang added this pull request to the merge queue Jan 16, 2025
Merged via the queue into apple:main with commit f5a859b Jan 16, 2025
6 checks passed
@ds-hwang ds-hwang deleted the dit branch January 16, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruomingp ruomingp ruomingp approved these changes

@markblee markblee Awaiting requested review from markblee markblee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds-hwang @ruomingp