-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sticky tables #311
base: v2
Are you sure you want to change the base?
feat: sticky tables #311
Conversation
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-04-01 14:03:38 CET |
commit: |
The changes move row position and max height calculations into separate helper functions for improved readability and maintainability.
Deployment failed with the following error:
|
@@ -5,6 +5,9 @@ | |||
export let columns: Array<Column> | number; | |||
export let allowSelection: boolean = false; | |||
export let selectedRows: Array<string> = []; | |||
export let maxRows: number = Infinity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does maxRows
sound a bit misleading? maybe maxVisibleRows
?
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)