fix(misconf): Improve logging for unsupported checks #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/iac/rego/load.go
Outdated
| @@ -165,15 +165,15 @@ func (s *Scanner) fallbackChecks(compiler *ast.Compiler) { | |||
| continue | |||
| } | |||
|
|
|||
| s.logger.Error( | |||
| s.logger.Debug( | |||
| "Error occurred while parsing. Trying to fallback to embedded check", | |||
There was a problem hiding this comment.
nit:
Can we somehow change the word Error?
Even if we show debug log, some users see word error and think it's an error.
There was a problem hiding this comment.
Hmm I agree - I updated it here 1bcf4c2
In the next release I want to add support inside of checks metadata to specify the minimum supported trivy version that the particular check would require to run.
That information will be used in this logic to only load those checks which are supported by that particular trivy version, thereby avoiding us getting into situations like these.
There was a problem hiding this comment.
Details on the new feature here #8637
There was a problem hiding this comment.
Details on the new feature here #8637
Looks good 👍
DmitriyLewen
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's no reason to print these logs on the error stream as it is not an error but simply lack of support.
Related issues
Checklist