feat: update grafana dashboard json, make dynamic datasource #332
Conversation
📝 WalkthroughWalkthroughThe Grafana dashboard configuration in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
monitoring/grafana/dashboards/default.json (1)
1032-1045: Addition of Datasource Templating VariableA new templating section now defines the
${datasource}variable with a default value of "prometheus". This is a clean and effective way to allow users to change the datasource dynamically without editing multiple panels.Consider adding inline documentation or a comment in the dashboard JSON (or associated documentation) to explain how to adjust the datasource templating settings for less technical users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
monitoring/grafana/dashboards/default.json(13 hunks)
🔇 Additional comments (10)
monitoring/grafana/dashboards/default.json (10)
25-25: Dynamic Datasource Update for Panel 1The datasource field in this panel has been updated to reference the variable
${datasource}instead of a static value. This change complies with the PR objective of making the dashboard dynamic, and the implementation is clear and concise.
90-90: Dynamic Datasource Update for Panel 2The datasource for this panel now uses
${datasource}. Verify that the new variable is correctly defined in the dashboard's templating section, and that any queries depending on this setting have been tested.
181-181: Dynamic Datasource Update for Panel 3The datasource field here is now updated to
${datasource}. This change is consistent with the dynamic configuration goal. Please confirm that the associated queries function normally with the variable reference.
292-292: Dynamic Datasource Update for Panel 4Updating the datasource to
${datasource}in this panel ensures consistency across your dashboard. It is recommended to verify that data retrieval remains unaffected when switching datasources dynamically.
401-401: Dynamic Datasource Update for Panel 5The datasource has been parameterized with
${datasource}. Ensure that any panel-specific query configurations properly accommodate this dynamic reference and that no dependency on a static datasource remains.
545-545: Dynamic Datasource Update for Panel 6The dynamic datasource reference
${datasource}is correctly applied here. Double-check that the default value defined later in the templating section (i.e. "prometheus") aligns with intended usage in production.
649-649: Dynamic Datasource Update for Panel 7This panel now uses
${datasource}for its datasource setting. Although the change is straightforward, validation that all queries continue to function as expected with the variable is recommended.
742-742: Dynamic Datasource Update for Panel 8The datasource field has been updated to the
${datasource}variable. Ensure that there are no conflicts with any other datasource-related settings in the dashboard.
838-838: Dynamic Datasource Update for Panel 9The datasource here is now dynamically referenced as
${datasource}. This meets the PR requirement; just verify that the previous integrations (such as in query evaluations) are all operating correctly.
928-928: Dynamic Datasource Update for Panel 10The datasource has been successfully replaced with
${datasource}in this panel. It’s important to ensure consistency in data source usage across the entire dashboard after this change.
|
these dashboards we have internally made with jsonnet/graphonnet. There's a chance we'll rather take that approach to dynamicism rather than javascript string manipulation of json. Let's see what other say :) thanks for your PR! 🙏 |
your welcome :) , just want to share what I faced before. It was cool if there's efficient way. |
The dashboard was defined with static datasource , so it's you need to modify it manually if ur grafana was installed in different server. I've add new panel "Datasource" for user select their datasource, also make the other panel integrated with the datasource panel.